search

houseabsolute / actions-rust-cross

GitHub Action to compile Rust with cross
Apache License 2.0
121 stars 13 forks source link

Put test 'args' at the end of the test command #30

Closed donatello closed 1 week ago

donatello commented 3 weeks ago

For test command, there can be arguments passed to the test binary like -- --ignored or -- --test-threads=1. For these cases to work properly, the args parameter needs to be added to the end of the 'test' command.

donatello commented 3 weeks ago

This is based on https://github.com/houseabsolute/actions-rust-cross/pull/12 and completes it by adding a test.

autarch commented 2 weeks ago

Hi, thanks for your PR! I'm pretty finicky about my projects (see this blog post for details), so I rarely merge a PR as-is. I can move forward on your PR in one of two ways:

  1. I check it out locally, fiddle with it as needed, merge it locally, and simply close this PR. This will preserve at least one commit with your name on it, but the PR will show up as closed in your GitHub stats.
  2. If you enable me to push directly to your fork, I can do my fiddling, then force push to your fork and merge the resulting PR. Again, this will preserve at least one commit with your name on it, but you also get credit for the PR merge in your GitHub stats. The only downside is that I will be force pushing directly to your fork.

Please let me know which approach you'd prefer. If I don't hear from you before I get around to working on this PR I'll go with option 1.

Thanks again for your contribution!

autarch commented 1 week ago

I merged this from the CLI.

autarch commented 1 week ago

Thanks!