houseabsolute / p5-Test-Vars

Detects unused variables in unit tests
https://metacpan.org/pod/Test::Vars
Other
6 stars 10 forks source link

Fix Windows #26

Closed schwern closed 8 years ago

schwern commented 8 years ago

This fixes Windows in a fairly simple manner, it just normalizes the path to be Unix style.

It also adds a config for AppVeyor, CI testing for Windows. You can turn this on at https://appveyor.com

Here's an example of it passing. https://ci.appveyor.com/project/schwern/p5-test-vars/build/1.0.1

Fixes #21 #7

autarch commented 8 years ago

I was tweaking this PR from the CLI and I'm getting odd failures - https://ci.appveyor.com/project/autarch/p5-test-vars

This failure actually happened before I made any appveyor.yml changes, but the config as you had it hid failures somehow. Here's my version of your branch - https://github.com/houseabsolute/p5-Test-Vars/pull/27

schwern commented 8 years ago

That looks like Perl is crashing. Chocolatey is using 5.20.1.1 and I've noticed it's not entirely stable. 5.20.3.3 is the latest 5.20 Strawberry release.

Try this? (I haven't yet) It should download and install Strawbery 5.20.3.3.

install:
  - ps: (new-object net.webclient).DownloadFile('http://strawberryperl.com/download/5.20.3.3/strawberry-perl-5.20.3.3-64bit.msi', 'strawberry-perl.msi')
  - ps: msiexec /i strawberry-perl.msi
  - set PATH=C:\strawberry\perl\bin;C:\strawberry\perl\site\bin;C:\strawberry\c\bin;%PATH%
  - cd C:\projects\%APPVEYOR_PROJECT_NAME%
autarch commented 8 years ago

I tried that but now it can't find cpanm.

schwern commented 8 years ago

I'll have to try it manually and figure out what's missing.

autarch commented 8 years ago

I have this working in #27