search

houseabsolute / p5-Test-Vars

Detects unused variables in unit tests
https://metacpan.org/pod/Test::Vars
Other
6 stars 10 forks source link

some prereqs are missing or out of date; minil.toml is missing #39

Closed karenetheridge closed 1 month ago

karenetheridge commented 4 years ago

The prerequisite list is incomplete/out of date; it would be extremely helpful if all prereqs were listed, even if they are core, as not every perl version can satisfy these dual-life requirements on their own (e.g. List::Util 1.33). Also, test prerequisites are still listed in the 'build' phase, rather than 'test'.

I would send a PR except that this is entirely a tooling matter, where author preferences can vary greatly. I would suggest removing Build.PL, META.* and MANIFEST from git and adding whatever config file (dist.ini, minil.toml etc) is used in the tooling.

autarch commented 4 years ago

Looking at older CPAN releases, I don't see any minil.toml files, and I don't see it in the Git history either. I'm guessing this has always used the defaults so you can just run minil release and it just works.

I'd prefer to replace this with dzil myself, though I'd want to make sure that @gfx has no objections.

That said, I wouldn't encourage use of this module. It has some bugs that I really don't feel like I can fix, just because it uses so much low-level Perl guts stuff. I think the Perl::Critic ProhibitUnusedVariables rule is a safer replacement. There's also https://metacpan.org/pod/Perl::Critic::Policy::Variables::ProhibitUnusedVarsStricter.

I suspect either of those would be easier to improve than fixing the bugs in this distro.

jkeenan commented 1 month ago

Please try Test-Vars-0.017, released today to CPAN. We're no longer using Minilla, so this ticket is moot. Thanks.