Updates for new OPs in Perl v5.38

houseabsolute / p5-Test-Vars

Detects unused variables in unit tests

https://metacpan.org/pod/Test::Vars

Other

6 stars 10 forks source link

Updates for new OPs in Perl v5.38 #52

Closed richardleach closed 2 months ago

richardleach commented 6 months ago

New optimized OPs were introduced in the 5.37 development cycle and require additional accounting in Test::Vars. Specifically:

PADSV_STORE - combines the functionality of PADSV + SASSIGN for some lexical scalar assignments (Perl/perl5@9fdd7fc)
AELEMFASTLEX_STORE - combines the functionality of AELEMFAST_LEX
- SASSIGN for some lexical array element assignments (Perl/perl5@aafefcb)

richardleach commented 6 months ago

Needs testing by someone other than me before merging!

hakonhagland commented 6 months ago

This works fine on Perl 5.38.1. All tests pass, in addition it also fixes the test failures reported for App::perlvars. Those test failures were fixed temporarily in https://github.com/perl-ide/App-perlvars/pull/12. Once this PR enters CPAN, that temporary fix should then be reverted.

richardleach commented 6 months ago

Great. Many thanks for testing.

twata1 commented 3 months ago

I was able to verify that all tests pass with the following Perl versions on Windows. 5.37.2 5.37.3 5.37.4 5.37.5 5.37.6 5.37.7 5.37.8

jkeenan commented 2 months ago

I tested this on almost all perlbrew-installed versions of perl between 5.14 and 5.40. All PASS; hence merged. Thanks.