Open shlomif opened 2 years ago
So you want to take over maintenance and the first thing you want to do is change all of the (totally working) dzil tooling? I'd be a lot more comfortable handing over maint to someone who had done some work that helps users of this distro first. There are a number of open issues that could use some attention.
So you want to take over maintenance and the first thing you want to do is change all of the (totally working) dzil tooling? I'd be a lot more comfortable handing over maint to someone who had done some work that helps users of this distro first. There are a number of open issues that could use some attention.
First of all, my desire to become a maint is orthogonal to this issue.
Secondly, i am unable to contribute with dzil test
locally failing. I am willinng2try that on a VM running a different linux distro or freebsd, but i am not buying a mac.
Changing from using CopyFilesFromBuild to CopyFilesFromRelease would be a reasonable solution to avoid the .md
files from being modified during development.
The modified files has nothing to do with why dzil test
fails though. The Pod spelling test is failing likely due to having a different spell checking utility installed. Adding the extra words that are listed in the test failure to .ispell_english
should be a reasonable solution to this.
On Mon, 11 Apr 2022 07:28:38 -0700 Graham Knop @.***> wrote:
Changing from using CopyFilesFromBuild to CopyFilesFromRelease would be a reasonable solution to avoid the
.md
files from being modified during development.The modified files has nothing to do with why
dzil test
fails though. The Pod spelling test is failing likely due to having a different spell checking utility installed. Adding the extra words that are listed in the test failure to.ispell_english
should be a reasonable solution to this.
Thx4the informative reply, Graham. ♥!
--
Shlomi Fish https://www.shlomifish.org/ My Aphorisms - https://www.shlomifish.org/humour.html
Tech needs less wizards, ninjas, and rockstars, and way more sociologists. — https://twitter.com/nslater/status/545592700289155072
Please reply to list if it's a mailing list post - https://shlom.in/reply .
@autarch : ping
I'd have to change this in my dzil bundle in order to change it for this one distribution. I do sometimes want to regen these files and check them in outside of a release.
So I don't think this is worth changing. It just means that when you run some dzil commands you may end up updating some of these files, and you then have to choose whether to revert them or check them in.
As for the spelling test, I'd welcome a PR to add those missing words to .ispell_english
. I'm surprised this doesn't fail for me. Maybe there's some file somewhere on my system that ispell finds that has those words in it, but I'm not sure what file that might be.
A good option for regenerating the files on demand is the [Regenerate::AfterReleasers]
plugin, with the dzil regenerate
command.
hi.
I'd have to change this in my dzil bundle in order to change it for this one distribution. I do sometimes want to regen these files and check them in outside of a release.
So I don't think this is worth changing. It just means that when you run some dzil commands you may end up updating some of these files, and you then have to choose whether to revert them or check them in.
Why not use @Filter
here:
https://metacpan.org/pod/Dist::Zilla::PluginBundle::Filter
As for the spelling test, I'd welcome a PR to add those missing words to
.ispell_english
. I'm surprised this doesn't fail for me. Maybe there's some file somewhere on my system that ispell finds that has those words in it, but I'm not sure what file that might be.
try strace?
@haarg @autarch : ping!
see below - I want the
.md
files to either stay out of repo or not be mutated. Moreover, per https://metacpan.org/dist/Code-TidyAll , I am willing to take over maint: https://metacpan.org/author/SHLOMIF .