houseabsolute / perl-code-tidyall

Engine for tidyall, your all-in-one code tidier and validator
https://metacpan.org/release/Code-TidyAll/
Other
21 stars 31 forks source link

Missing dependency #127

Open Tux opened 10 months ago

Tux commented 10 months ago
t/Plugin-PerlCritic.t ..........
    #   Failed test 'error message'
    #   at ~/.cpan/build/Code-TidyAll-0.84-0/t/lib/TestFor/Code/TidyAll/Plugin.pm line 93.
    #   (in TestFor::Code::TidyAll::Plugin::PerlCritic->test_main)
    #                   'Running [perlcritic --profile /tmp/Code-TidyAll-Dxv3/perlcriticrc /tmp/Code-TidyAll-xkYu/foo.txt] failed
    #     exited with 2 - output was:
    # Can't locate Pod/PlainText.pm in @INC (you may need to install the Pod::PlainText module) (@INC entries checked:
--- Makefile.PL.org     2023-12-12 09:49:33.974351052 +0100
+++ Makefile.PL 2023-12-12 09:49:39.438408844 +0100
@@ -45,6 +45,7 @@ my %WriteMakefileArgs = (
     "Moo" => "2.000000",
     "Moo::Role" => 0,
     "Path::Tiny" => "0.098",
+    "Pod::PlainText" => 0,
     "Scalar::Util" => 0,
     "Scope::Guard" => 0,
     "Specio" => "0.40",
--- cpanfile.org        2023-12-12 09:50:30.206945823 +0100
+++ cpanfile    2023-12-12 09:50:33.946985381 +0100
@@ -49,6 +49,7 @@ on 'test' => sub {
   requires "ExtUtils::MakeMaker" => "0";
   requires "File::Spec" => "0";
   requires "FindBin" => "0";
+  requires "Pod::PlainText" => 0;
   requires "Test::Class::Most" => "0";
   requires "Test::Differences" => "0";
   requires "Test::Fatal" => "0";
All tests successful.
Files=24, Tests=301,  8 wallclock secs ( 0.06 usr  0.01 sys +  7.42 cusr  0.75 csys =  8.24 CPU)
Result: PASS
autarch commented 10 months ago

I'm a bit confused why this is necessary. Nothing in the tidyall code references this module.

Tux commented 10 months ago

maybe a (newer) version of Perl::Tidy requires it (during test)

autarch commented 10 months ago

maybe a (newer) version of Perl::Tidy requires it (during test)

I think you mean Perl::Critic. And yes, Perl::Critic does require Pod::PlainText, but it's listed in Perl::Critic's dependencies. So I'm not sure why it didn't get installed for you.

That said, I did just find that tidyall didn't include Perl::Critic as a develop phase requirement, so I fixed that.