houseabsolute / perl-code-tidyall

Engine for tidyall, your all-in-one code tidier and validator
https://metacpan.org/release/Code-TidyAll/
Other
21 stars 31 forks source link

Consolidate git status code. #57

Closed finn closed 8 years ago

finn commented 8 years ago
finn commented 8 years ago

@autarch: This should fix issue #56

I didn't think it warranted any test changes since it was a refactor.

The relevant tests still pass for me locally which I am taking as a good sign. Waiting for the travis ci results.

finn commented 8 years ago

(I also corrected the version number listed in README.md)

autarch commented 8 years ago

There's no need to touch the README.md. It's auto-generated.

autarch commented 8 years ago

The rest of the PR looks good. Thanks! I'll merge once Travis passes.

autarch commented 8 years ago

Well, once it passes modulo a new test that's breaking for reasons outside of your control. Don't worry about the clean namespaces test.

finn commented 8 years ago

Great! Re-pushed w/o README changes.

finn commented 8 years ago

As predicted t/author-clean-namespaces.t failed -- but everything else looks ok in travis.

autarch commented 8 years ago

Thanks for working on this. I merged this from the CLI with a few small tweaks.

finn commented 8 years ago

:+1: