search

houseabsolute / perl-code-tidyall

Engine for tidyall, your all-in-one code tidier and validator
https://metacpan.org/release/Code-TidyAll/
Other
21 stars 31 forks source link

chdir to $ROOT before running commands #86

Closed oalders closed 7 years ago

oalders commented 7 years ago

This fixes Perl::Critic spell checks, which look for a stopwords file that might be a file relative to the root directory.

Fixes #85

autarch commented 7 years ago

Rebasing off master should fix the CI failures.

oalders commented 7 years ago

I rebased, but that one commit I was missing shouldn't be the problem. It looks to me like t/lib is not being included by the call to prove on Travis.

autarch commented 7 years ago

Master is passing, so I'm inclined to blame your changes ;)

I'm guessing that it has to do with things like writing use lib 't/lib' relying on the process having a specific current directory.

oalders commented 7 years ago

This is passing now, even if the solution is kind of nasty. You have any better ideas? I'm getting some local failures on dzil test --all, but it might just be my setup. It would be worthwhile checking that this actually works before merging.

If this is ok, it might be a good idea to squash when merging so that the test failure from the first commit doesn't mess with git bisect.

autarch commented 7 years ago

I merged this from the CLI. Thanks!

oalders commented 7 years ago

Thanks @autarch!