housepower / ClickHouse-Native-JDBC

ClickHouse Native Protocol JDBC implementation
https://housepower.github.io/ClickHouse-Native-JDBC/
Apache License 2.0
527 stars 145 forks source link

fix date value error when bigger than short #383

Closed liuneng1994 closed 2 years ago

liuneng1994 commented 2 years ago

When date value is bigger than short range, the value will error. because clickhouse date is uint16

codecov[bot] commented 2 years ago

Codecov Report

Merging #383 (25284f1) into master (f99ab4e) will increase coverage by 0.46%. The diff coverage is 92.77%.

Impacted file tree graph

@@             Coverage Diff              @@
##             master     #383      +/-   ##
============================================
+ Coverage     61.90%   62.37%   +0.46%     
- Complexity     1230     1248      +18     
============================================
  Files           134      135       +1     
  Lines          6579     6631      +52     
  Branches        508      516       +8     
============================================
+ Hits           4073     4136      +63     
+ Misses         2228     2219       -9     
+ Partials        278      276       -2     
Impacted Files Coverage Δ
.../github/housepower/settings/ClickHouseDefines.java 0.00% <ø> (-75.00%) :arrow_down:
...hub/housepower/data/ColumnWriterBufferFactory.java 70.58% <70.58%> (ø)
...rc/main/java/com/github/housepower/data/Block.java 91.17% <91.66%> (-0.06%) :arrow_down:
.../com/github/housepower/buffer/ByteArrayWriter.java 100.00% <100.00%> (+29.62%) :arrow_up:
...com/github/housepower/data/ColumnWriterBuffer.java 100.00% <100.00%> (ø)
.../com/github/housepower/data/type/DataTypeDate.java 62.50% <100.00%> (ø)
...c/statement/ClickHousePreparedInsertStatement.java 52.90% <100.00%> (+0.27%) :arrow_up:
.../com/github/housepower/serde/BinarySerializer.java 94.73% <100.00%> (+0.53%) :arrow_up:
...ava/com/github/housepower/data/AbstractColumn.java 85.71% <0.00%> (+7.14%) :arrow_up:
... and 2 more

Continue to review full report at Codecov.

Legend - Click here to learn more Δ = absolute <relative> (impact), ø = not affected, ? = missing data Powered by Codecov. Last update 03a3fa3...25284f1. Read the comment docs.

pan3793 commented 2 years ago

Thanks, merging to master/2.6