search

housepower / clickhouse_sinker

Easily load data from kafka to ClickHouse
https://housepower.github.io/clickhouse_sinker
Apache License 2.0
515 stars 118 forks source link

The progress cant stop #136

Closed tuliyao closed 2 years ago

tuliyao commented 2 years ago

sql's tx need to execute tx.Rollback(). create tx will new a goroutinue, it closed when execute tx.Commit() or tx.Rollback(), when run code failed in Begin and Commit, your code not run Rollback to release this new goroutinue. it maybe cause the progress cant stop. and I met it.

yuzhichang commented 2 years ago

Good catch! Fixed at master tip 28cb7d64020a3514915530c068d4a23494c2f840.