search

housepower / clickhouse_sinker

Easily load data from kafka to ClickHouse
https://housepower.github.io/clickhouse_sinker
Apache License 2.0
519 stars 117 forks source link

remove unnecessary newticker #17

Closed taiyang-li closed 5 years ago

taiyang-li commented 5 years ago

I found that there are several NewTicker assigned to the same variable in task.go. So I remove the redundant one.

sundy-li commented 5 years ago

I intend to do this, yet it's not very well.

When the task flushes a batch by max count reach condition. The ticker should reset, because the next batch may be very small.