housepower / clickhouse_sinker

Easily load data from kafka to ClickHouse
https://housepower.github.io/clickhouse_sinker
Apache License 2.0
519 stars 117 forks source link

Is this code on CH commit error correct? #36

Closed ns-gzhang closed 4 years ago

ns-gzhang commented 4 years ago

https://github.com/housepower/clickhouse_sinker/blob/59ee004146c02e87a87bbb9f4a3e1772130b431a/output/clickhouse.go#L112-L116

It seems to silence the commit error... Thanks.

sundy-li commented 4 years ago

Right,it's a bug, I will fix that.