search

housleyjk / ws-rs

Lightweight, event-driven WebSockets for Rust.
MIT License
1.47k stars 222 forks source link

Switch to standard rust HTTP types #161

Open thomas-jeepe opened 7 years ago

thomas-jeepe commented 7 years ago

Fairly recently this crate https://github.com/carllerche/http was created for the purpose that it states.

I think using the crate as part of the ws::Handshake would be a good idea as it is a standard and there is less reimplemented logic.

PS: The main reason I looked into this is because I wanted to access query parameters from the handshake and there was no method to get the full path or url.

Edit: I found the resource method on the request, so that part is fine, but query parsing still needs to be done separately.

housleyjk commented 7 years ago

I noticed the http crate a little bit ago, and I do plan on switching to it. I just don't know the timeframe yet.