search

houssamham / plcrashreporter

Automatically exported from code.google.com/p/plcrashreporter
Other
1 stars 0 forks source link

Please post a build for armv7s architecture #48

Closed GoogleCodeExporter closed 9 years ago

GoogleCodeExporter commented 9 years ago 
The new Xcode 4.5 requires armv7s to submit app updates that support the iPhone 
5. Your posted binaries are built for armv6 and armv7 only.

Original issue reported on code.google.com by webmas...@getjustlanded.com on 13 Sep 2012 at 1:26

GoogleCodeExporter commented 9 years ago 
This is an extremely high priority issue. No apps compiled with the iOS 6 GM 
SDK will be able to release to the App Store or testers, as armv7s is now 
required. This includes Hockey and other libraries that rely on PLCrashReporter.

Original comment by bcapps...@gmail.com on 13 Sep 2012 at 2:06

GoogleCodeExporter commented 9 years ago 
Agree, we need armv7s compatibility as soon as possible

Original comment by victor.m...@gmail.com on 20 Sep 2012 at 8:11

GoogleCodeExporter commented 9 years ago 
I was able to compile by applying the attached patch with
patch -p1 < updateArmv7s.patch
to the plcrashreporter-1.1-beta1.tar.gz codebase.
And then using Xcode 4.5, run
xcodebuild -configuration Release -target 'Disk Image'
from within the directory.
This creates a build directory, with the compiled framework that you can use.

Original comment by jvanme...@burnsidedigital.com on 21 Sep 2012 at 6:27

Attachments:

GoogleCodeExporter commented 9 years ago 
I can confirm that the patch works well in the simulator and on existing armv7 
devices running ios6.

Original comment by zeil...@gmail.com on 22 Sep 2012 at 7:06

GoogleCodeExporter commented 9 years ago 
Unfortunately, the patch is incorrect for two reasons, both explained in the 
comment around PLCrashReportSystemInfo.h:60:
• "The architecture value has been deprecated in v1.1 and later crash 
reports. All new reports will make use of the new PLCrashReportProcessorInfo 
CPU type encodings."
• "These enum values match the protobuf values. Keep them synchronized."

The second comment is more subtle: redefining the meaning of 6 breaks 
forward/backward-compatibility. Fortunately, it looks like the value was never 
actually written (yet).

The correct fix is probably to just save the architecture as 
PLCrashReportArchitectureUnknown and let the decoder figure it out from the 
processor info, which is saved as Mach-O CPU type/subtype.

Original comment by tc...@airsource.co.uk on 2 Oct 2012 at 5:21

GoogleCodeExporter commented 9 years ago 
Issue 50 has been merged into this issue.

Original comment by landon.j.fuller@gmail.com on 6 Oct 2012 at 7:46

GoogleCodeExporter commented 9 years ago 
tchan is correct. I've committed an initial patch in trunk@r454, but am on 
vacation and can not immediately test on real devices. If anyone has time to 
test, please give trunk a try and report back.

Original comment by landon.j.fuller@gmail.com on 6 Oct 2012 at 8:16

GoogleCodeExporter commented 9 years ago 
Is a pacth for this fix available. Can you please publish it

Original comment by ibrahima...@gmail.com on 2 Nov 2012 at 10:13

GoogleCodeExporter commented 9 years ago 
With more and more armv7s devices in the wild, the need for a solution to this 
issue is becoming more important. Is there any progress? Thanks for the great 
work.

Original comment by rma...@gmail.com on 27 Nov 2012 at 6:19

GoogleCodeExporter commented 9 years ago

Original comment by landon.j.fuller@gmail.com on 27 Nov 2012 at 6:40

GoogleCodeExporter commented 9 years ago 
A new release, 1.1-rc1, has been posted on the project main page now that 
supports armv7s (and consequently drops support for older architectures like 
armv6 that are not supported by Xcode 4.5). Please try it out and report any 
issues.

Original comment by nick.bar...@gmail.com on 28 Nov 2012 at 6:33

GoogleCodeExporter commented 9 years ago

Original comment by nick.bar...@gmail.com on 28 Nov 2012 at 6:38