housseindjirdeh / angular2-hn

:boom: Progressive Hacker News client built with Angular
https://angular2-hn.firebaseapp.com
MIT License
1.3k stars 233 forks source link

Added detection of user's system preffered color scheme on load #83

Closed Erbenos closed 4 years ago

Erbenos commented 4 years ago

Changes live when preferred scheme changes as well. Value saved in localStorage has priority on load.

The first time I did anything in Angular so if you have any idea for a better way to implement such a feature, please let me know.

Maybe separate service?

housseindjirdeh commented 4 years ago

This is great, thank you!

Ideally it would be nice to abstract to a separate service, but I'm okay with keeping this within the context of SettingsService for now :)