Closed grapevine2383 closed 1 year ago
Thanks for the report! Will try to reproduce when I have 2 monitors nearby
Could likely reproduce using a virtual monitor too
I don't have physical Windows machine and on my Debian box all is fine. But looks like window is closed before all stuff for break is done.
Yes it takes a couple seconds to fully load on all monitors and if i need to skip it before it fully loads then it crashes it. It would be a good idea to code an exception catch in there or have it abort when skipped
Hey could you check new version, I've made some changes in how break windows are handled .
Thank you for looking into fixing this bug. Unfortunately it is still happening with version 1.11.0. Most recent crash log below:
[2022-08-18 17:01:21.187] [info] Stretchly: showing window 1 of 8
[2022-08-18 17:01:21.188] [info] Stretchly: starting Long Break
[2022-08-18 17:01:21.219] [info] Stretchly: showing window 2 of 8
[2022-08-18 17:01:21.475] [info] Stretchly: showing window 4 of 8
[2022-08-18 17:01:22.095] [info] Stretchly: showing window 3 of 8
[2022-08-18 17:01:22.146] [info] Stretchly: showing window 6 of 8
[2022-08-18 17:01:22.398] [info] Stretchly: showing window 5 of 8
[2022-08-18 17:01:22.854] [info] Stretchly: postponing Long Break
[2022-08-18 17:01:22.876] [info] Stretchly: showing window 7 of 8
[2022-08-18 17:01:22.884] [info] Stretchly: showing window 8 of 8
[2022-08-18 17:01:23.778] [error] TypeError: Cannot read properties of null (reading 'center')
at Timeout._onTimeout (C:\Users\user\AppData\Local\Programs\Stretchly\resources\app.asar\main.js:879:25)
at listOnTimeout (node:internal/timers:559:17)
at process.processTimers (node:internal/timers:502:7)
[2022-08-18 17:01:23.781] [error] TypeError: Cannot read properties of null (reading 'center')
at Timeout._onTimeout (C:\Users\user\AppData\Local\Programs\Stretchly\resources\app.asar\main.js:879:25)
at listOnTimeout (node:internal/timers:559:17)
at process.processTimers (node:internal/timers:502:7)
It gives 2 errors in this case. I'm guessing one error for each window.
It seems like one the lines in main.js like:
setTimeout(() => {
breakWinLocal.center()
}, 0)
is causing the crash. Maybe just change it to "if(breakWinLocal){breakWinLocal.center()}" for all occurrences? Though it might still crash later down the script if other breakWinLocal operations are done after without a null check
Do you have 8 monitors?
Yes
Hey, I made some changes in 1.12, is this still happening?
Looks like it stopped happening so far. I will report back if it still continues
Thanks! Will close for now :)
This issue still happens unfortunately. But it looks like it has been reduced?
Version
Known issues
Existing issues
What operating system are you using?
Windows
Operating System Version
Windows 10 Pro 21H2
Reproduction steps
**Reproduces how often: 100% [What percentage of the time does it reproduce?]
Expected Behavior
No crashing should happen
Actual Behavior
It crashes
Relevant log output
Preferences
Additional information
Code of Conduct