hovancik / stretchly

The break time reminder app
https://hovancik.net/stretchly
BSD 2-Clause "Simplified" License
4.56k stars 441 forks source link

[Bug]: Needs to unpack node on Windows #1342

Open stutf opened 1 year ago

stutf commented 1 year ago

Version

Known issues

Existing issues

Advanced Preferences

What operating system are you using?

Windows

Operating System Version

Windows 11 22H2 x64

Reproduction steps

  1. Launching Stretchly always creates the error every time.

Expected Behavior

I would like Stretchly to open and run.

Actual Behavior

stretchlyerror

Relevant log output

From Windows Event Viewer

Code Integrity determined that a process (\Device\HarddiskVolume3\Program Files\Stretchly\Stretchly.exe) attempted to load \Device\HarddiskVolume3\Users\xxxxxxxxxx\AppData\Local\Temp\c47fa814-131b-4f58-beec-d8b2cc2b81e9.tmp.node that did not meet the Enterprise signing level requirements or violated code integrity policy (Policy ID:{b112b106-4b8f-4e69-8301-881ae511d511}).

Preferences

No response

Additional information

I'm pretty sure that it is Windows Defender Application Control that is blocking Stretchly. I have allowed all the files in the Stretchly directory, but Stretchly is trying to load files from temporary files - see the 'log output' which is from Windows Event Viewer. Does Stretchly really need to be using files that are in temporary files? I really don't want to be allowlisting anything from the temp directory.

Code of Conduct

hovancik commented 1 year ago

Hi and thanks for the report. Not sure if Stretchly needs some temp files, but looks like it does. I am using Electron.js which does all the work for me and I pretty much just write some JS code.

Also, how did you install? Maybe installing from Windows Store would help? Just added that recently.

stutf commented 1 year ago

Hi Jan, Thanks for your quick reply and for your time in making and supporting Stretchly. I installed it from the .exe file and the 'all users' option. Today, I have uninstalled that one and have installed the Windows Store version, but same result, unfortunately. I found this https://github.com/brave/browser-laptop/issues/12534 which sounds like the exact same problem. Is that able to be done for Stretchly?

hovancik commented 1 year ago

Hi, yeah, I am already doing some unpacks for some reason, so we could also add node: https://github.com/hovancik/stretchly/blob/61b2a79352073a615f69de6883caf969f8782825/package.json#L101. If you have time, feel free to create a PR. Would be nice if you could try creating installer and test it out. For some reason I am not able to build stretchly on my Windows laptop ;/

hovancik commented 1 year ago

@stutf so I managed to build on windows, can you try? https://conta.noho.st/nextcloud/s/ALabg7i4wKKCGoP

But this increased the size of the installer to almost 300MB, which is pretty wild, so not sure whether I want to proceed with this fix.