Closed evgenyneu closed 1 month ago
I've made some comments, let me know what you think :)
I can test then on Windows as well.
I've made the improvements you suggested. Also, I managed to install the dev environment on Windows, and tested the shortcuts on all platforms. Let me know if you want to change/improve anything. :D
I can squash and merge, unless you want to add yourself to the readme :)
Thanks, squash is ok, I don't need readme mention :D
Issue: #1457
Requirements
node
version specified inpackage.json
was used (ie using nvm).npm install --no-save
).npm run lint
reports no offenses.npm run test
is error-free.Description of the Change
main.js
intoutils/breakShortcuts.js
.Verification Process
Restart the app.
Use the keyboard shortcuts and see that the breaks are paused: the app icon changes to Pause and when you click the text shows the correct pause duration.
Since I moved the code for other break shortcuts into, I also tested these shortcuts:
I tested it on Mac, Windows and Ubuntu.