search

hove-io / transit_model

Managing transit data with Rust
GNU Affero General Public License v3.0
53 stars 28 forks source link

tests fail without feature #551

Closed datanel closed 4 years ago

datanel commented 4 years ago 
warning: unused import: `super::*`
  --> src/validity_period.rs:68:9
   |
68 |     use super::*;
   |         ^^^^^^^^
   |
   = note: `#[warn(unused_imports)]` on by default

error[E0432]: unresolved import `transit_model::netex_france`
  --> tests/write_netex_france.rs:17:41fs2ntfs(test), transfers(test), apply_r   |(test), filter_ntfs(test), merge_stop_areas(test), gtfs_reader(example)   17 | use transit_model::{self, model::Model, netex_france, test_utils::*};
   |                                         ^^^^^^^^^^^^ no `netex_france` in the root

error: aborting due to previous error

For more information about this error, try `rustc --explain E0432`.
error: could not compile `transit_model`.
warning: build failed, waiting for other jobs to finish...
error: build failed

I think you should run test with and without features on travis.

woshilapin commented 4 years ago

In an ideal world, I guess we should launch all the possible combinations of feature. But we could start with no features AND all features indeed. Thanks for the report

woshilapin commented 4 years ago

PR #552 should fix the situation and improve a little bit the CI.

datanel commented 4 years ago

fixed with https://github.com/CanalTP/transit_model/pull/552