Closed christopheblin closed 2 years ago
I believe the documentation might be a bit misleading.
Two parameters can be specified in the configuration of the converter
I see you put odt
and odt_comment
in the navitia.json
. I believe you can remove them. Try the following instead.
docker exec --rm -it -v $PWD:/data --entrypoint /bin/sh navitia/transit_model:v0.51.0 \
gtfs2ntfs \
--input /data/gtfs \
--config /data/navitia.json \
--prefix vss \
--output /data/ntfs \
--odt \
--odt-comment "Ceci est un test"
Tell me if that works better. If this was the problem, we should probably fix a little bit the documentation.
@woshilapin yes it works (at least for the comments.txt+comment_links.txt on stop_time), thank you !
From there, what should I expect to behave differently in navitia ?
At the moment (without --odt), when I request a journey on this trip
Please note that setting all the timestamps to the same value is from the doc at https://github.com/hove-io/ntfs-specification/blob/master/ntfs_fr.md#ligne-arr%C3%AAt-%C3%A0-arr%C3%AAt-sans-horaires
On the calculus part, I'm not familiar enough with ODT and how it's handle on Navitia. I'll try to see if I can find someone that can help on that.
@woshilapin ok thank you, I've made a test on my side with --odt and I still have the exact same behavior on the journey requests -> either I did something wrong or the --odt has no impact on the trip planner, which is a bit disappointing to me ...
@christopheblin If i'm reading your GTFS right, each stop_time is available to drop_off (drop_off_type=2 => Must phone agency to arrange drop off).
If you want to avoid a speed of light travel, you may try to change 07:00:00
stop_times with a drop_off_type=1 (No drop off available.)
@prhod thanks for the suggestion : it means that the TAD trip will not appear anymore in any journey request, but it's fine for my use case
@woshilapin I think that the doc could be improved for --odt as you said (i.e just showing the CLI is fine I think). Thanks again for the support.
@christopheblin with my suggestion, with a A > B > C > D trip, you will be able to have a journey from A to D, B to D and C to D, but not from A to B. I thought it was the intended behaviour looking at your GTFS. Maybe it was not ;)
@christopheblin I created #855. Tell me if that looks better, and don't hesitate to tell if this can be even better. An outsider is usually better on that kind of things :wink:
@prhod ah I see what you mean, thanks for the clarification !
however, the current GTFS data are A -> B -> C -> .... -> X and all stop_times have 7am except X which is 7PM (but some travelers want to do B -> P for ex)
The correct way here I think would be to change the timestamps to match reality at 7 am and then to declare a frequency of 10 or 15 minutes with pickup_type=drop_off_type=2
Thank you again for the support :+1:
I'm closing the issue.Feel free to reopen if necessary
I try the following commands and I expect that gtfs2ntfs would create a comments.txt and a comment_links.txt for ODT as indicated in the docs
To summarize in a human friendly way what I did
Am I doing something wrong or is there a bug ?
Dont hesitate to ask more details if needed
Some details
https://github.com/hove-io/transit_model/blob/master/documentation/gtfs_to_ntfs_specs.md#prepending-data
https://github.com/hove-io/transit_model/blob/master/documentation/gtfs_to_ntfs_specs.md#reading-stop_timestxt
Commands