hove-io / transit_model

Managing transit data with Rust
GNU Affero General Public License v3.0
53 stars 28 forks source link

gtfs2netexfr : wrong StopPlaceType for bus #888

Closed nlehuby closed 1 year ago

nlehuby commented 1 year ago

Hi guys :wave:

Currently, in the Netex FR exports, all mono-modal StopPlace relative to bus gets a StopPlace/StopPlaceType that is busStation.

But busStation is supposed to be used for bus stations ("Gare routière", according to the documentation) And in most cases, your mono-modal StopPlaces are not actual bus stations...

If it is not possible to differentiate between cases where the stop_area is a bus station and cases where it is not, it would be preferable to use onstreetBus ("Arrêt de bus sur la voirie") value for the StopPlace/StopPlaceType.

AntoineAugusti commented 1 year ago

Relevant lines https://github.com/hove-io/transit_model/blob/fde57f45db38dc43add264f6498646b9061cde13/src/netex_france/stops.rs#L493-L504

stifoon commented 1 year ago

Hi @nlehuby, Your second proposed solution is very simple, and the value of the modification is obviously beneficial for the software. Moreover, it is open source, and you are a brilliant developer, so you could do it ;) However, fixing the source code will not be enough. It will also be necessary to

At this point, we have no contact, no ordering party, and no project with transport.data.gouv.fr. And unfortunately, we have lots of other priority, this enhancement being not identified by none of our customers.

We keep the issue open, maybe in a few month we will reconsider it ! Stephan

fchabouis commented 1 year ago

Hello @stifoon, This is Francis Chabouis from transport.data.gouv.fr. We asked @nlehuby to open an issue because we are interested to know your opinion about the relevance and the technical feasibility of her proposition. Thank you in advance for your help

ArnaudOggy commented 1 year ago

@nlehuby, @AntoineAugusti , @fchabouis

The PR https://github.com/hove-io/transit_model/pull/891 has been merged and is present in release v0.55.0. Since we unfortunately don't have a defined validation process between Hove and transport.data.gouv.fr we let you see if there is any downstream impact.

More generally we know that the converter would need an update (to the v2.2 france-profile), and we would like to work on it. Frame structures, ID suffixes, maybe calendars, and several other points would need to be updated.

Unfortunately, after searching, there is apparently no maintenance contract with transport.data.gouv.fr to update this converter regularly. And we lack "free" time to do it ourselves. Which saddens us all because like you we understand its usefulness. So there are only two solutions left:

fchabouis commented 1 year ago

Thank you @ArnaudOggy and @nlehuby . We will investigate this maintenance issue and come back to you.