search

hovel / imagestore

Django gallery solution.
BSD 3-Clause "New" or "Revised" License
164 stars 71 forks source link

Extend fields for title and image's URL in BaseImage. #44

Closed kmitrovic closed 9 years ago

kmitrovic commented 9 years ago

As field in extended Django ORM classes cannot be overwritten, I set max_length to 256 to title and image URL fields in the BaseImage class. Maybe this is helpful for others, so I'm sending a pull request.

GeyseR commented 9 years ago

Some notes on your pull request:

  1. Why did you choose 256 characters length? There is restriction in django docs to 255 characters for models, which should be portable between DB backends.
  2. Django 1.7 compatibility check is fixed in https://github.com/hovel/imagestore/commit/c2c205d2084b5a4d164f8fb33d2d92f3388d6022. Please rebase your branch on master for clean merge
  3. Please exclude .gitignore changes from your PR. This is your environment related changes.
kmitrovic commented 9 years ago

Pull request altered (max_length on both fields is 255). Note that I changed the original commit in the pull request (I suppose that nobody did the previous 0016 migration but me, so we could use this to have only one instead of two migrations).

GeyseR commented 9 years ago

Thanks!

kmitrovic commented 9 years ago

Any time :)

Do you have any estimation on when will there be a new version set on PyPi?