search

hovel / imagestore

Django gallery solution.
BSD 3-Clause "New" or "Revised" License
164 stars 71 forks source link

cms carousel plugin does not work #5

Closed herrri closed 12 years ago

herrri commented 12 years ago

The cms carousel plugin doesn't work, because in the file: imagestore_album_carousel.html

the line 2: {% include template %}

does not work. Includes cannot be 'dynamic'. So this argument needs to be a string, not a variable.

Here might be an answer to it: http://groups.google.com/group/django-users/browse_thread/thread/e82080309234413d. I'll dig into it.

herrri commented 12 years ago

Okay I forked the code a bit. I think there are some pending design decisions that need to be made, because people use different image carousels. So there needs to be some kind of abstraction between different carousels. But all in all i forked the code and added a setting to the settings.py:

IMAGESTORE_CAROUSEL_TEMPLATE = 'imagestore/imagecarousel.html'

Where the developed can override the default template. Note that this is a really hackish way to implement what I want.

Fork found here: https://github.com/herrri/imagestore

A pull request might a good idea after code revision.

zeus commented 12 years ago

Changes has been merged to master