Closed skolsuper closed 7 years ago
LGTM but If I may bring my 2cts:
mark_read
call should not be conditioned. Your condition should be in the mark_read
method (with a direct return) to allow developers to easily override this method and do special stuff if user is not authenticated (for example, mark ad read via Cookies ?)time.sleep(1)
if DB does not support microsecond between the post creation and the post access ?Forget the third point : I'm working on a PR to remove those @skipUnlessDBFeature
. There is still a test which always fails with MySQL, even with sleep
calls. I think there is a bug in pybbm read tracking system with MySQL. If you want to have a look on the WIP : webu/pybbm@ec7d7d808be5237b6d550e5c01ebba5274d50194
@skolsuper : see #258 for the third point.
Agree with points 1 and 2 but don't have time to fix. I have given push access to my fork so you can touch up this branch if you think it's worthwhile.
@skolsuper I rebase the PR and add points 1 and 2. Thanks for the access.
Better late than never :) Thank you.
Two reasons for moving the method call:
This PR also modifies an inefficient query in
mark_read
that checks for unread topics in forum.