hover2pi / svo_filters

A Python wrapper for the SVO Filter Profile Service
MIT License
13 stars 4 forks source link

add check for strictly monotonically increasing wavelength to Filter class wave property. #38

Closed emirkmo closed 2 years ago

emirkmo commented 2 years ago

(Which is required by common astro-python packages like specutils, etc.) This PR adds (a relatively convoluted, but tested) strict monotonically increasing check to the wavelength property Filter.wave, if parameter monotonic is True (the default).

We also add a test for this working with a known filter profile that breaks it (the ZTF one).

Fixes #35.

Some details:

hover2pi commented 2 years ago

Merging into develop instead of master so I can make the release.