search

hoverbike1 / TOTK-Mods-collection

Mod repo for Tears of The Kingdom (TOTK) for Switch and Switch Emulation
Apache License 2.0
3.03k stars 201 forks source link

All combos with 60fps so far locked at 30fps #30

Closed physixtential closed 1 year ago

physixtential commented 1 year ago

Sorry I'm sure I'm missing something and not sure where else to reach out. I've been successfully using a 60fps mod outside of your mod paks, but every version of 60fps you have provided, including the 1.4.4 update with

image

is just locked at 30fps for me. I have vsync off, and I know I can get 60 fps. Any clues as to why these just don't work vs others?

I am on zelda update 1.1.0 btw.

hoverbike1 commented 1 year ago

5 instances of missing of @stop from 60 fps memory values being patched. Thanks for pointing this out! I have pushed a new version, available for download now: https://github.com/HolographicWings/TOTK-Mods-collection/releases/tag/v.1.4.4

Please test and report back.

Uranite commented 1 year ago

5 instances of missing of @Stop from 60 fps memory values being patched. Thanks for pointing this out! I have pushed a new version, available for download now: v.1.4.4 (release)

Please test and report back.

For some reason this causes totk to crash on launch

molnizzle commented 1 year ago

Same for me. Every 60fps mod in this repo causes crash on launch for me.

physixtential commented 1 year ago

5 instances of missing of @Stop from 60 fps memory values being patched. Thanks for pointing this out! I have pushed a new version, available for download now: https://github.com/HolographicWings/TOTK-Mods-collection/releases/tag/v.1.4.4

Please test and report back.

Can confirm other replies. This instantly crashes yuzu. Thanks for working on it.

physixtential commented 1 year ago

I just diffed your combo vs the 60fps file I know works (I don't remember where I got it...)

image

I have no modding experience. Just a C++ programmer. I don't know what those extra two lines they have are doing.

Uranite commented 1 year ago

Just add an empty line under the @stop, it fixes the crash

HolographicWings commented 1 year ago

I found several missing @enabled too, i fixed that, i'm definitely against combo mods.

molnizzle commented 1 year ago

@Uranite it works! Thanks

@HolographicWings I disagree tbh, the stuff included in this bundle is basically good for anyone playing TotK. I really like it just needs to work lol

HolographicWings commented 1 year ago

@Uranite it works! Thanks

@HolographicWings I disagree tbh, the stuff included in this bundle is basically good for anyone playing TotK. I really like it just needs to work lol

it's exhausting to read their work to correct everything. And we have to apply the new updates to every combo. I'll don't remove them anyway.

hoverbike1 commented 1 year ago

Just add an empty line under the @stop, it fixes the crash

Thanks for pointing this out fixed 👍

HolographicWings commented 1 year ago

Sorry I'm sure I'm missing something and not sure where else to reach out. I've been successfully using a 60fps mod outside of your mod paks, but every version of 60fps you have provided, including the 1.4.4 update with image is just locked at 30fps for me. I have vsync off, and I know I can get 60 fps. Any clues as to why these just don't work vs others?

I am on zelda update 1.1.0 btw.

everything is fixed