hoverbike1 / TOTK-Mods-collection

Mod repo for Tears of The Kingdom (TOTK) for Switch and Switch Emulation
Apache License 2.0
3.03k stars 201 forks source link

Disable Dynamic Resolution causes crash after loading save file (Steam Deck) #39

Closed vgf89 closed 1 year ago

vgf89 commented 1 year ago

I'm on a steam deck (stable channel for OS and client), with TOTK 1.1.1 and 1.5.5 mods collection. Enabling the "Disable Dynamic resolution when low FPS" mod causes Yuzu to freeze then crash when the save file ~finishes loading but before it actually gets in game (the Zelda logo loading bar fills, then it completely freezes and yuzu closes a while later) I was mistaken, it freezes right after the loading screen opens.~ It varies, sometimes it crashes at the beginning of the loading screen, sometimes at the end right before the fade, and very rarely it reaches in game before freezing and crashing.

I've tried on mainline 1436, 1439, and EA 3499. Exact same crash behavior in all of them. It crashes even if the dynamic resolution disabler is the only enabled mod.

EDIT: corrected info about when precisely the freeze/crash happens.

HolographicWings commented 1 year ago

Hello, can you send me a log after the crash ?

vgf89 commented 1 year ago

yuzu_log.txt

HolographicWings commented 1 year ago

[6219.214119] Debug core/hle/service/filesystem/fsp_srv.cpp:operator():899: Assertion Failed!

hmm, i don't understand this error what happen without this mod ?

vgf89 commented 1 year ago

Right? The error looks like it has nothing to do with what the mod should be changing. And yet the game loads in normally if I don't use the mod.

As I said, 1436, 1439, EA 3499, and now EA 3601 all freeze then crash on that line, soon after the loading screen opens following me opening the save file, if the mod is active. The game loads in fine if the mod is off. I've tried deleting and adding the mod again too, no change.

If I uncheck the update (so the game is on 1.0.0) but leave the mod checked, it gets past the initial Yuzu launching bar then crashes a few seconds later on the black screen, and it produces the exact same error as the crash that happens after loading a save in 1.1.1. If I disable the mod then 1.0.0 launches normally and I can load my save and get in game fine. Here's the log from the 1.0.0+mod run: yuzu_log.txt

vgf89 commented 1 year ago

Odd discovery: if I run a combo pack that includes the dynres disabler (1.1.1, 1.1.0 - Resolution - New 1008p -FXAA Off, FSR Off, DynRes Off -Zero AO Bugs) from the 1.6.1 mod collection, instead of the individual pchtxt dynamic resolution mod, it loads fine? Hmm...

vgf89 commented 1 year ago

I'm finding that the exact point it crashes can actually vary. Sometimes it crashes at the beginning of the loading screen, sometimes at the end, and rarely it crashes right after getting in-game. It also doesn't always produce a log, but usually it does, and it's that same fsp_srv 899 assertion failed every time.

I'm at a loss.

HolographicWings commented 1 year ago

Honestly i don't know, i haven't made the mod and i never used a Steam Deck Only thing i can advice you is to don't use the "Disable Dynamic Resolution when low FPS" this mod is really specific and not really required in any setup I added an adviced configuration on the documentation.

Mario-119 commented 1 year ago

Same issue on my Steam Deck, using the latest Yuzu EA (3602 at time of writing) and the TotK 1.1.1 update

HolographicWings commented 1 year ago

This mod is only usefull when you run under 30fps anyway And i'm unsure the steamdeck can hold ryuginx in a constant 30fps

Mario-119 commented 1 year ago

Ryujinx is only getting 15-20 FPS for me on my Deck, Yuzu is hanging anywhere from 25-35 FPS usually

HolographicWings commented 1 year ago

Ryujinx is only getting 15-20 FPS for me on my Deck, Yuzu is hanging anywhere from 25-35 FPS usually

i think that deserve a mention to @Foul-Tarnished who love to tease people using yuzu :P

HolographicWings commented 1 year ago

Steam Deck bad

btw giga brain to have piracy links inside credits.txt for some mods lmfao

Yes i thanks you to warned me, i changed them

reptarien commented 1 year ago

This happens for me on the free 1441 build as well. Next to instant crash with the latest version of this mod enabled specifically; I tried it both with some other mods on and just the 1.1.1 update, with no other mods: same result, load in, see the world for a few seconds (at most), crash. I'm using a RTX 3060 and Ryzen 5 1600, I had been playing the game with earlier editions of the mod on 1.1.0 fine. There is something wrong with the mod itself.

EDIT: I can also confirm that like OP said, the combo mod does not have this issue for me either. Works a charm, and was the combination of mods I was going to use anyway, so It's an alright bandaid, even though I'm not a fan of combo patches.

TheKingEngineRevUp commented 1 year ago

I too am experiencing this issue

Dark-talon commented 1 year ago

newest yuzu builds should fix crashes, please test

vgf89 commented 1 year ago

Still crashes on EA 3612 for me :-/

Mario-119 commented 1 year ago

Yup, issue is persisting here as well (unless using a multi-pack)

SpockBauru commented 1 year ago

Disable Dynamic Resolution removed from the repository. It was causing too many issues.