search

hoverinc / tableau-utilities

A module and CLI Utility for managing Tableau objects, locally, and in Tableau Online.
MIT License
4 stars 1 forks source link

remove requirements and put packages in install_requires #26

Closed jaybythebay closed 1 year ago

jaybythebay commented 1 year ago

@JustinGrilli when a teammate of mine installed the dependencies weren't installed. What do you think of putting these in the setup so it will always get installed?

If you're cool with this merge it in.

JustinGrilli commented 1 year ago

Ah thanks! @jaybythebay Yeah, I've been meaning to fix this too.

I think I'd like to keep the requirements files just for development purposes. But yeah we can either manually specify the requirements like you have it here, or we can reference the requirements -> prod.txt file in setup.py for install_requirements. I think I lean toward the latter, especial if you agree we should keep the requirements file for development use.

EDIT -- Okay, I looked into this a little bit, and I changed my mind 😆 (docs): I think it is actually good that we specify the packages as you've done here. Would you mind adding some version bounds to each of the packages we have listed? Also, it would still be good to keep the requirements files for dev use - but we can simplify it to one file instead of splitting it into dev/prod like I did before. We don't need to specify the same version bounds in the requirements.txt file, so we can dev with the latest versions of each packages - in case there are updates we need to make to keep things up-to-date with the latest versions.

jaybythebay commented 1 year ago

@JustinGrilli sounds good. Check this out.

jaybythebay commented 1 year ago

@JustinGrilli sounds good. Check this out.