hovski / ecommerce-pattern-library

A term-long project redesigning an ecommerce website focusing on making a pattern library.
https://stupefied-mccarthy-ee9958.netlify.com/pattern-library/#brand
0 stars 0 forks source link

Final Grade #13

Open hovski opened 5 years ago

hovski commented 5 years ago

I feel like I should get an A for this assignment. It fully represents all the components needed in the assignment requirements + it has multiple variations within my pattern library. I spent a great deal of time explaining how someone should do something — if they needed to hop into my code and code something themselves. I've left a lot of additional patterns incase anyone needed more options as well. So they wouldn't need to ask me anything really, and I'd provide a very thorough wireframe as well. My teammates didn't struggle when putting my product details page together — both teammates completed it within 5-10 minutes. I am not missing any components to my website — nor are there incomplete components.

I really struggled wrapping my head around the process. Building the items individually was a tad bit easier, however, linking gemfiles + all the additional stuff was really hard to take in. I still don't understand it even though I've completed the work. I've re-read some of the assignments that are directional and I found a lot of the pictures were confusing but I feel that was more of a me thing + I'm not much of a coding individual (unfortunately). There were a few weeks that felt way more overwhelming than others — the .md filing for each product was a bit much. I know I had a ton of products (more than some others) but, I felt like that week was super stressful on the whole. I also found understanding the include.data."name here" hard to wrap my mind around and still don't understand how that links within things. On the whole, not terrible but really confusing.


Style & design3

Fantastic: the whole pattern library feels cohesive & well designed. I spent a lot of time finessing the content in XD before swapping it over. Very little was changed from the original design — except for the footers. The footers were supposed to be split into 1/2 grid formation but instead I designed it to stack.

Patterns3

All imagined patterns, including patterns not used on the template pages.

Explanations3

Excellent & clear, perfect for another person to work from. I wrote tons for someone to hop onto my Pattern Library and have no difficulty whatsoever. They could easy log into this assignment and make a random page if need be.

Accessibility3

Works really well under all the standard accessibility tests. I even made my tab targeting the bright orange to really contrast against everything I have laying out on my website.

Semantics3

Excellent demonstration of HTML tags and correct use.

Responsiveness2

Responsive but with lots of awkwardness. I wouldn't say lots of awkwardness but there is some awkwardness when it comes to my footer navigations. They just sit weird.

Code Quality3

Perfect: semantics, indentation & accessibility. I spent a lot of time going through my stuff and double checking these things. Mainly because I wanted to really nail it this time around so that I could use it next year for our next assignment (our personal websites).

Git Comments0

I'm never really descriptive when it comes to commits. Sometimes I often just put whatever even though it doesn't relate to the content because I know that I'm the only one working on it — So I don't have to rely on someone else seeing it anyhow. It's something I should improve on.

21/24 — 87.5%