search

hovski / ecommerce-pattern-library

A term-long project redesigning an ecommerce website focusing on making a pattern library.
https://stupefied-mccarthy-ee9958.netlify.com/pattern-library/#brand
0 stars 0 forks source link

Pattern Library - Typography White Text #2

Open hovski opened 5 years ago

hovski commented 5 years ago

@thomasjbradley

I've finished the typography part of our homework and I'm pretty sure I did it correctly, but theres couple of issues I'm having:

  1. I set the yellow highlight to my orange highlight. But it's is still staying yellow on my localhost refresh no matter what I do.
  2. I set my links to white (I realize the background is white so I'm assuming since my Pattern library background is white it'll just stay black for other issues - however, for links they're still showing up blue and wasn't sure if that's normal?)
  3. All my content is taking in weight and font-variants into consideration but I'd assume the white staying black is normal.

Let me know if there's something I'm doing wrong or if this is all normal. Thanks!

thomasjbradley commented 5 years ago

I think it’s because all the variables are written incorrectly. The values are being repeated, when only the variables’ names should be used, e.g.:

h5 {
  color: var(--color-black);
  font-family: var(--font-primary);
  font-weight: bold;
}

Notice how the color & font-family variables are only the names, the values should only be written at the top, inside :root.