howToCodeWell / code-quiz

Code Quiz MonoRepo (API, API Client, App)
MIT License
4 stars 4 forks source link

#120 Remove the port #127

Closed metinbaris closed 2 years ago

metinbaris commented 2 years ago

Fixes #120

metinbaris commented 2 years ago

@pfwd Have one question, is it ok use it without url slash ?

There is "/" http://localhost/ at the end of url as described "#120 Acceptance Criteria"

To use the given port I had to change also test description for yarn test would please review it for me :)

pfwd commented 2 years ago

@pfwd Have one question, is it ok use it without url slash ?

There is "/" http://localhost/ at the end of url as described "#120 Acceptance Criteria"

To use the given port I had to change also test description for yarn test would please review it for me :)

Good question. I haven't tried it without the slash.
Now you mention it, I actually prefer the API_BASE_PATH to not have the trailing slash so we can define that in the routes. It should be ok as https://github.com/howToCodeWell/code-quiz/blob/9564ab3194a8fffbba358bbd343dc0a12951c385/api-client/src/api/requestHandlers/quizRequest.ts#L4 starts with the slash. This is covered by the following integration test https://github.com/howToCodeWell/code-quiz/blob/9564ab3194a8fffbba358bbd343dc0a12951c385/api-client/tests/integration/api/requestHandlers/quizRequest.test.ts#L14

Could you try and remove it from the update the unit test? If the integration test fails then I may need to rethink how it works.

metinbaris commented 2 years ago

@pfwd Just pushed the change, yes if we remove the slash at the end of the baseURL, requests should work fine