howaboutwe / experimental

MIT License
20 stars 2 forks source link

Minimizes complexity in experimental loader #38

Closed bryanwoods closed 10 years ago

bryanwoods commented 10 years ago
oggy commented 10 years ago

Hmm, I think I find this less readable.

Part of it is the name updated_active_experiments doesn't sound like it modifies anything. More generally I think breaking up the methods like this clouds the structure of what the loader is doing (creating, updating, removing). Perhaps there's a way to refactor this to maintain the single level of abstraction principle?