search

howanghk / homebridge-ewelink

Homebridge plugin to control Sonoff relays with OEM firmware
MIT License
81 stars 46 forks source link

Extra Fan Devices #99

Closed bwp91 closed 4 years ago

bwp91 commented 4 years ago

Hi, this is my first ever post so please bear with me. Also right at this moment can’t post details of configs/logs. All was working with version 0.1.21 but since I have updated to 0.1.23 I am having... not problems with using the accessories. But for every dual sonoff light switch I have in my house there is now a fan accessory that appears in homekit. There have been no changes to the T1-1C devices but for every T1-2C device I have, both lights appear in homekit and work as normal, but there is an extra “fan” accessory which appears. Thanks Ben

fizulnizam commented 4 years ago

I have the same issue, albeit I'm using a three gang light switch.

ozzyobr commented 4 years ago

Same here

Snowblu commented 4 years ago

Ditto, for what its worth.

bwp91 commented 4 years ago

I have found a solution, but i’m so new to github i’m not sure how to fix it.

Snowblu commented 4 years ago

Wish I could help. Took me half a day to figure out the comment section!!

ozzyobr commented 4 years ago

I would love to test it, can you add the fix here? I should have a final version of my fix this week. @howanghk how to we proceed with the merge requests?

bwp91 commented 4 years ago

The issue I found was with this change: https://github.com/howanghk/homebridge-ewelink/commit/89a17456bee405fd2fcfd10889dee49882660d37 Where the || deviceToAdd.extra.extra.model === "PSF-B04-GL" has been added. In my case I don't have any sonoff fans so deleting this change is sufficient for me.

bwp91 commented 4 years ago

I am very slowly getting to know the functionality of this site. I have made a fork of this and made the deletion in my previous comment. I have also changed some of the log text so it seems more natural. https://github.com/thepotterfamily/homebridge-ewelink-max-tpf

ozzyobr commented 4 years ago

I'm learning as well. I want to be able to control the master switch gang which turns on/off all gang members at the same time. As you said the master switch is being seen as a fan, but it is actually a switch.

bwp91 commented 4 years ago

I'm learning as well. I want to be able to control the master switch gang which turns on/off all gang members at the same time. As you said the master switch is being seen as a fan, but it is actually a switch.

Ah, I have no interest in the master switches, I have disabled them through the ewelink app— i just assumed that that’s why that don’t get picked up in homebridge.

howanghk commented 4 years ago

this should be fixed in 0.1.24

ozzyobr commented 4 years ago

I'm learning as well. I want to be able to control the master switch gang which turns on/off all gang members at the same time. As you said the master switch is being seen as a fan, but it is actually a switch.

Ah, I have no interest in the master switches, I have disabled them through the ewelink app— i just assumed that that’s why that don’t get picked up in homebridge.

yup, did you check if the extra fan devices are the master switches? all master switches are displayed as fans for me. I've 7 multi gang switches, so that is why I'm interested in getting them configured properly. My focus now is to fix the multiple updates back to ewelink that make the switches go crazy (and other multi channel devices like the 4CH pro).

bwp91 commented 4 years ago

this should be fixed in 0.1.24

This has fixed the issue for me. Thanks @howanghk

ozzyobr commented 4 years ago

Also fixed for me, thanks @howanghk

Snowblu commented 4 years ago

Fixed! Thank you very much.

bwp91 commented 4 years ago

@ozzyobr if i enable the master switches in the ewelink app will they appear in homebridge? Just out of interest

fizulnizam commented 4 years ago

Can you push the plugin update onto HOOBS?

howanghk commented 4 years ago

@fizulnizam All HOOBS support will be done by HOOBS. HOOBS Users should visit their support site: https://support.hoobs.org instead of posting on github issues.