search

howardabrams / demo-it

An Emacs package for running demonstrations, screencasts and presentations from within Emacs.
GNU General Public License v2.0
324 stars 32 forks source link

fixed erasing read-only eshell buffer #1

Closed shlomiv closed 8 years ago

shlomiv commented 9 years ago

Hey, I am really enjoying watching your emacs vids and reading your literate emacs configuration, thanks!

While playing with demo-it, I was getting "let: Text is read-only" when trying to demo a command in eshell. It seems that the buffer is read-only, so erase-buffer failed. I wrapped it with inhibit-read-only and it seems to work well now.

Thanks!

howardabrams commented 8 years ago

Thank you for the pull request ... I actually didn't notice it until I had changed the code in a backward incompatible way. I have merged your change, and from now on (since others are actually using this), I will pay better attention!

Oh, and I promise to try hard and not make incompatible changes without asking first.

shlomiv commented 8 years ago

Hey, Thanks, However, trying to make a new presentation using demo-it, I hit this problem again.. demo-it-start-eshell function has a call to (erase-buffer) which results in a demo-it-start-eshell: Text is read-only and the command doesnt run.

Re-applying the patch I submitted long ago fixes that. Just so you know :)