howardabrams / demo-it

An Emacs package for running demonstrations, screencasts and presentations from within Emacs.
GNU General Public License v2.0
324 stars 32 forks source link

Add demo-it-presentation-jump-to-link #14

Closed nickbarnwell closed 6 years ago

nickbarnwell commented 6 years ago

Sorry for bombarding you with PRs! If you rather I just maintain a fork, do let me know!

This function allows you to jump directly to a header or line as stored by org-store-link.

The motivation for this fn was being able to easily organise my demo-it presentations into a series of functions that could be moved around without relying on having state built up and keeping track of what the nextdemo-it-presentation-advance call will do.

howardabrams commented 6 years ago

Interesting idea. Let's merge this. Terribly sorry for the delay in getting back to you. Let me update the org base documentation (and generate the Info document from it). Any more examples you'd like me to include (or would you like to take a stab at it first)?

Thanks again for suggesting this.

nickbarnwell commented 6 years ago

I have a bunch of examples here, but they're functionally all the same. Is there anything you think needs to be added?

howardabrams commented 6 years ago

I guess I was looking for a simple use case, and an explanation of how this function is different from the demo-it--presentation-section with takes a string, and moves the currently displayed presentation to a particular section header, which if shown with org-tree-slide, jumps to that slide.

nickbarnwell commented 6 years ago

Oh, I hadn't found demo-it--presentation-section before. I guess the advantage of this is that it would also work with org-links to a specific file and line, but is probably unnecessary for the original use case given the function you just pointed me to. I haven't used it in the way I just mentioned, and text-size and other things would be incorrect compared to using the demo-it find-file equivalents.

If it were me, I'd reject the PR :)

howardabrams commented 6 years ago

:-D

Alright, I will, but I do appreciate you playing with it and coming up with a good idea. Seems like I need to make that function more noticeable in the documentation, so I'll work on that idea.

Thanks again.