Closed RutgerLubbers closed 5 years ago
Wow, this is a big one! Thanks! It'll take a little while to go through, but a couple of immediate comments: 1) What's Q24-Readme? 2) You're right about the approach not being the intended one, but hey, I haven't really documented that either. This will work. (specifically - the PDO queries you've added are already in MapManager which is intended to be the home for all the non-Cacti-specific parts of the management plugin)
This looks great though, I'll be reading some more later tonight!
Rutger - one other thing that I thought I'd already done, but it turns out I haven't yet. I'm planning to change the license for Weathermap from GPL to MIT. Since this PR is the first major code contribution, I thought I should let you know before anything gets merged, in case that is a problem for you.
Howard, we're fine with the licence change.
Rutger
I think it can be merge and then change by you requests
@RutgerLubbers can you change?
I merged and then fixed the permissions.
Thith it right
Although it doesn't actually pass the tests. You ran the tests, right, Rutger?
@howardjones that's still the ext-snmp
error we haven't managed to resolve.
Fixed - the default group ID for a new map should be 1 not 0.
No, this was a unit test failing that previously didn’t. Travis is building cleanly now.
https://travis-ci.org/howardjones/network-weathermap/jobs/437817023
On Fri, 5 Oct 2018 at 22:24, Mark Brugnoli-Vinten notifications@github.com wrote:
@howardjones https://github.com/howardjones that's still the ext-snmp error we haven't managed to resolve.
— You are receiving this because you were mentioned.
Reply to this email directly, view it on GitHub https://github.com/howardjones/network-weathermap/pull/157#issuecomment-427502902, or mute the thread https://github.com/notifications/unsubscribe-auth/AA3sJRhDhEwbcDrhRUsE171zN5EB2ft_ks5uh830gaJpZM4Wry5n .
I didn't see that one 👍
Anyway - UI is moving forwards... thanks, Rutger & co! :-)
Hi Howard,
as per previous pull request, this PR with some functionality fixes. We've bundled them together.
The changes are: Management:
Weathermap:
General:
These changes may not be as you would like to see the final release, but it is working now (a bit more :-) ).
Kind regards,
Rutger Lubbers