search

howardjones / network-weathermap

Network Weathermap draws diagrams from data
http://www.network-weathermap.com/
MIT License
425 stars 95 forks source link

Datasource external #204

Closed vKnmnn closed 5 years ago

vKnmnn commented 5 years ago

The datasource_external plugin references the WeatherMapDataSource class wich cannot be found. Did you maybe forget this one while refactoring? I can't find the corresponding class, sadly, so i would be grateful for a fix.

Cheers

2018/12/11 15:07:34 - ERROR PHP ERROR in Plugin 'weathermap': Class 'WeatherMapDataSource' not found in file: /usr/local/share/cacti/plugins/weathermap/lib/Weathermap/Plugins/Datasources/WeatherMapDataSource_external.php on line: 23
howardjones commented 5 years ago

Oops, I guess I did, because it's not normally a .php file, so phpstorm wouldn't have indexed it.

The new base class is just called 'Base'. If you look at the top of any of the other DS plugins, you'll see how it's supposed to look. Otherwise I'll push a change later.

pautiina commented 5 years ago

If fixed it's can be closed