howardjones / network-weathermap

Network Weathermap draws diagrams from data
http://www.network-weathermap.com/
MIT License
426 stars 94 forks source link

Aggregate maps only show "out" direction data on 0.98 #39

Closed philip-davis closed 7 years ago

philip-davis commented 8 years ago

It looks like the wmrrd_read_from_real_rrdtool_aggregate function drops first line of RRDTool output, but using RRDtool 1.5.5, there is no leading blank line in the output of the rrdtool command. So I lose the first ("IN:") line. If I comment out lib/datasources/WeatherMapDataSource_rrd.php line 276, it works as expected.

howardjones commented 8 years ago

Thanks for the report! That's helpful of it. I'll add a check if there actual is a blank line.

howardjones commented 7 years ago

This is changed in the current git repo to automatically detect if the line is there or not.

The 'database-refactor' fork has the latest version here: https://github.com/howardjones/network-weathermap/tree/database-refactor/lib/datasources