Update curve25519-dalek dependency to 1.2.3.

howardwu / wagyu

A Rust library for generating cryptocurrency wallets

https://wagyu.dev

Apache License 2.0

612 stars 106 forks source link

Update curve25519-dalek dependency to 1.2.3. #69

Closed hdevalence closed 5 years ago

hdevalence commented 5 years ago

The Scalar::from_bits function allows constructing unreduced scalars with exactly the given bit pattern, for compatibility with X/Ed2559. Prior to 1.2.3, this API had a sharp edge where it was possible to construct unreduced scalars, then perform certain operations on them, and compute incorrect results. This was fixed in 1.2.3; I don't believe it affected any actually existing code.

hdevalence commented 5 years ago

Hoping I got the target branch correct; if not, feel free to cherry-pick or just replicate the change :)