howdyai / botkit-docs

Documentation for #botkit
https://botkit.ai/docs
18 stars 59 forks source link

Documenting new promises in lib/Facebook.js #22

Open HassenIO opened 5 years ago

HassenIO commented 5 years ago

Hi all, 👋

This follows my current work on "Allow Promises when on Facebook API calls" of botkit, actually still in PR #1520.

I would like to have a first feedback on how to properly document the promise way of some methods, in addition to the classical callback way.

Here is an example, currently in my fork https://github.com/htaidirt/botkit-docs/commit/c8f393ce2739d4c5fc3c7466650cd6608101d351. Given your feedbacks, I'll continue documenting similarly the remaining methods.

Thanks

ouadie-lahdioui commented 5 years ago

Hi @htaidirt, I've taken a look at your fork and it sounds great.

Go Go Go

benbrown commented 5 years ago

@htaidirt since the promise code has been released, let's get these docs updated!