howdyai / botkit-storage-mongo

A MongoDB storage driver for Botkit
MIT License
54 stars 42 forks source link

Add Remove #30

Closed zealot2323 closed 6 years ago

zealot2323 commented 7 years ago

Right now there is no way to remove records using this library. This would be helpful and is something the simple storage can already do.

alexsmanning commented 6 years ago

@zealot2323: I just put in a PR for this, it should hopefully get pushed in soon enough! https://github.com/howdyai/botkit-storage-mongo/pull/31

ken9ross commented 6 years ago

@peterswimm Any idea when the PR from alexsmanning is likely to be applied? I have need of that functionality and would prefer to keep with an unmodified library if possible.

peterswimm commented 6 years ago

@ken9ross No timeframe atm, but I will ping the team to take a look.

ken9ross commented 6 years ago

Hi @peterswimm Any response to your ping?

peterswimm commented 6 years ago

@ken9ross its been merged! Closing this topic for now.

ken9ross commented 6 years ago

@peterswimm Any idea as to when npm will receive the updated version?

peterswimm commented 6 years ago

@ken9ross I added it to our next sprint, so within the next week or so.

ken9ross commented 6 years ago

@peterswimm npm still only reports botkit-storage-mongo as v1.0.6 (ie without delete). Any update on when we can expect it?

ken9ross commented 6 years ago

Any update @benbrown (just in case the closed status is throwing you)?

Laptopmini commented 6 years ago

Node currently has v1.0.7 which does NOT have the delete method. I'm gonna pull directly from this git in the mean time.

npm install howdyai/botkit-storage-mongo --save

nerboda commented 5 years ago

@benbrown any reason this hasn't been pushed to the registry yet?