howdyai / botkit

Botkit is an open source developer tool for building chat bots, apps and custom integrations for major messaging platforms.
MIT License
11.48k stars 2.28k forks source link

Bot Framework Skype channel regular expressions not working #1205

Closed gcfabri closed 6 years ago

gcfabri commented 6 years ago

Bot Info

Issue Description

I built a bot using Bot Framework (node.js) with four connected channels (Messenger, Telegram, Skype and Web). At any moment the bot validates an inputted email address using a regular expression like this below:

/^[-a-z0-9~!$%^&*_=+}{\'?]+(\.[-a-z0-9~!$%^&*_=+}{\'?]+)*@([a-z0-9_][-a-z0-9_]*(\.[-a-z0-9_]+)*\.(aero|arpa|biz|com|coop|edu|gov|info|int|mil|museum|name|net|org|pro|travel|mobi|[a-z][a-z])|([0-9]{1,3}\.[0-9]{1,3}\.[0-9]{1,3}\.[0-9]{1,3}))(:[0-9]{1,5})?$/i

It is working properly on all channels, except the Skype. E.g: gcfabri@gmail.com match with this regex but on Skype channel it doesn't happens.

Code Example

emailRegex.test(gcfabri@gmail.com);

Expected Behavior

The email address gcfabri@gmail.com should match with the regex above.

Actual Results

Skype channel just ignore the step with the regex validation.

peterswimm commented 6 years ago

The fact that three out of four platforms work makes me think this is a Bot Framework problem, have you tried creating an issue on their Github? https://github.com/Microsoft/BotBuilder

Botkit is just passing information to Botframework, so if Skype needs special preparation, on their end would the best place for that to happen.