howdyai / botkit

Botkit is an open source developer tool for building chat bots, apps and custom integrations for major messaging platforms.
MIT License
11.46k stars 2.28k forks source link

Remove implicit request dependency #2185

Open draaglom opened 2 years ago

draaglom commented 2 years ago

Motivation: request is implicitly depended on by botbuilder-adapter-slack but it's not in package.json.

This means we want to either:

Given request is long since deprecated and usage in botbuilder-adapter-slack is minimal (just this one request), the latter seems most sensible.

Of candidate HTTP clients to swap out, node-fetch seems the obvious choice:

Where I'd like your advice with this PR:

ghost commented 2 years ago

CLA assistant check
All CLA requirements met.

stale[bot] commented 2 years ago

This issue has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs. Thank you for your contributions.