Zero percent growth - Githubissues

howdyai / botmetrics

Analytics and Engagement for Makers and Marketers of Chat and Voice bots

https://www.getbotmetrics.com

Other

234 stars 46 forks source link

Zero percent growth #25

Closed OrthoDex closed 8 years ago

OrthoDex commented 8 years ago

removed the inf label as per @danieldraper 's suggestion.

arunthampi commented 8 years ago

Nice work @OrthoDex 🙌 few things:

[ ] can you rebase against master?
[ ] There are some changes in Gemfile.lock (can you please revert those changes?)

Otherwise LGTM to merge

OrthoDex commented 8 years ago

@Hey @arunthampi , I rebased and reverted the changes to Gemfile.lock, it updated a few gem versions to the later ones when I ran bundle. Sorry about that :disappointed_relieved:

arunthampi commented 8 years ago

@OrthoDex nice thanks! sorry one more change, I think it's better to not show anything instead of showing 0%. In bots_helper, if growth is nil then it won't show anything so shall we return nil instead of 0.0?

Thanks again for your work 🙏

OrthoDex commented 8 years ago

Oh yeah, now that i see that part of the code, it makes sense to not show anything. My bad, i'll fix it in a sec.

arunthampi commented 8 years ago

nice thanks! will merge once CI passes

OrthoDex commented 8 years ago

Thank you! I am looking to contribute more to this repo, so hopefully I can be of further help :smile: