search

howeyc / fsnotify

File system notification for Go
BSD 3-Clause "New" or "Revised" License
1.99k stars 252 forks source link

WIP: fixed fsnFlags race condition on linux #103

Closed bobrik closed 10 years ago

bobrik commented 10 years ago

This fixes #102, but only on linux. I'd like to see some comments before fixing it for every platform.

nathany commented 10 years ago

Hi Ian. Over at https://github.com/fsnotify/fsnotify (see #101) I've removed WatchFlags entirely, and put together a different strategy for filtering (see https://github.com/fsnotify/fsnotify/issues/7)

@howeyc Would you like continued work on bugfixes such as this and #93?

howeyc commented 10 years ago

I'm not going to merge this because it looks like it will break on other platforms.

However, I will be accepting fixes until there is a package in the standard library. I will also not make any changes to API, I assume that's what go-fsnotify is attempting.

nathany commented 10 years ago

Thanks @howeyc. I'll try to backport bugfixes where I can.

bobrik commented 10 years ago

I'll close this one, but keep #102 then.