Closed nathany closed 10 years ago
You may want to wait until https://codereview.appspot.com/58500043/ is merged before merging this.
@kardianos @eaburns @mirtchovski @parkghost @romanoff @kylelemons
GoDoc indicates that you have a package that imports code.google.com/p/go.exp/fsnotify
.
Please be aware that go.exp is experimental and the API will be changing over the next few weeks. If you don't want to update your package in lock-step, consider importing github.com/howeyc/fsnotify
. Thanks!
Thanks for the heads up.
On Fri Jan 31 2014 at 11:13:39 PM, Nathan Youngman notifications@github.com wrote:
@kardianos https://github.com/kardianos @eaburnshttps://github.com/eaburns @mirtchovski https://github.com/mirtchovski @parkghosthttps://github.com/parkghost @romanoff https://github.com/romanoff @kylelemonshttps://github.com/kylelemons
GoDoc indicateshttp://godoc.org/code.google.com/p/go.exp/fsnotify?importersthat you have a package that imports code.google.com/p/go.exp/fsnotify.
Please be aware that go.exp is experimental and the API will be changing over the next few weeks. If you don't want to update your package in lock-step, consider importing github.com/howeyc/fsnotify. Thanks!
— Reply to this email directly or view it on GitHubhttps://github.com/howeyc/fsnotify/pull/84#issuecomment-33863104 .
I'll drop a note here once https://codereview.appspot.com/58500043/ is merged. Until then I don't recommend importing go.exp/fsnotify
- unless you want to leap back in time.
@howeyc Should we try to apply bug fixes to both repositories while only changing the API at go.exp/fsnotify?
I'm not sure to whom this question is directed, but since I'm CCed, I'll answer.
If it's not hard to fix the bugs in both places then it's nice to have fewer bugs out in the wild. However, I haven't seen any issues with my Watch program using the howeyec repository, so if it's going to be a big time sink to fix both, then I don't mind waiting for go.exp to get the fixes.
On Thu Feb 06 2014 at 9:44:21 AM, Nathan Youngman notifications@github.com wrote:
@howeyc https://github.com/howeyc Should we try to apply bug fixes to both repositories while only changing the API at go.exp/fsnotify?
— Reply to this email directly or view it on GitHubhttps://github.com/howeyc/fsnotify/pull/84#issuecomment-34328763 .
CL 58500043 has been merged. https://codereview.appspot.com/58500043/ So now both repositories match.
@eaburns I agree. Maybe we can fix a few issues before jumping on the API changes.
Go 1.3 will include os/fsnotify in the standard library with a new API.
code.google.com/p/go.exp/fsnotify
(GoDoc) for the latest API under development.github.com/howeyc/fsnotify
(GoDoc) for the stable API.code.google.com/p/go.exp/fsnotify