Remove current implementation of WatchFlags - Githubissues

howeyc / fsnotify

File system notification for Go

BSD 3-Clause "New" or "Revised" License

1.99k stars 252 forks source link

Remove current implementation of WatchFlags #96

Closed nathany closed 10 years ago

nathany commented 10 years ago

removes fsnFlags, purgeEvents and internalEvent channel

current implementation doesn't take advantage of OS for efficiency
provides little benefit over filtering events as they are received, but has extra bookkeeping and mutexes
no tests for the current implementation
not fully implemented on Windows https://github.com/howeyc/fsnotify/issues/93#issuecomment-39285195

TODO: go.exp CL for this.