search

howmanysmall / Janitor

Janitor library.
https://howmanysmall.github.io/Janitor/
MIT License
107 stars 17 forks source link

Added Promise Library from Wally #21

Closed christopher-buss closed 2 years ago

christopher-buss commented 2 years ago

An implementation for using Wally to install the Promise dependency.

The concern is the fact that this would no longer provide support for non-wally implementations of Janitor when using the Promsie library, as it directly accesses the Promise library through the wally install.

OverHash commented 2 years ago

Unfortunately this breaks roblox-ts workflows.

You definitely should be committing wally.lock as well.

howmanysmall commented 2 years ago

I also don't want to force people to install Promise if they don't want it, that's why I have it the way it is. Wally doesn't have something akin to the optional dependencies I think NPM has.