howtoosee / pe

0 stars 0 forks source link

Violation of SLAP #13

Open howtoosee opened 3 years ago

howtoosee commented 3 years ago

Constructors should not be in charge of data validation

Screenshot 2020-11-13 at 17.29.14.jpg

nus-se-bot commented 3 years ago

Team's Response

SLAP has nothing to do with whatever has been highlighted here.

AB3 follows a similar implementation, where string inputs are validated inside the constructor.

Furthermore, this is not a documentation quality bug.

Items for the Tester to Verify

:question: Issue response

Team chose [response.Rejected]

[ ] I disagree

Reason for disagreement: [replace this with your reason]