howtoosee / pe

0 stars 0 forks source link

Unintuitive guard clauses used #14

Open howtoosee opened 3 years ago

howtoosee commented 3 years ago

Some guard clauses are not given as proper conditions, such as add and add-expense or add-income

Screenshot 2020-11-13 at 17.31.54.jpg

nus-se-bot commented 3 years ago

Team's Response

This diagram is a summary of the logic described earlier (on page 15), so the reader should know that the decision is with regards to the command that was entered.

From an example in the textbook, guard conditions need not be very explictly defined as proper conditions if it's clear what it's referring to. Under Activity Diagrams -> Introduction -> What:

image.png

Items for the Tester to Verify

:question: Issue response

Team chose [response.Rejected]

Reason for disagreement: [replace this with your reason]


:question: Issue severity

Team chose [severity.Low] Originally [severity.Medium]

Reason for disagreement: [replace this with your reason]